ext/soap: Fix SOAP classmap validation for integer keys#22884
Open
LamentXU123 wants to merge 2 commits into
Open
ext/soap: Fix SOAP classmap validation for integer keys#22884LamentXU123 wants to merge 2 commits into
LamentXU123 wants to merge 2 commits into
Conversation
Member
|
could you add the following test please ? |
LamentXU123
force-pushed
the
soap-todo
branch
2 times, most recently
from
July 25, 2026 12:08
732faef to
751d593
Compare
Member
Author
|
This is indeed a bug when SoapClient::_classmap can be reflected as a packed array :) |
Member
|
I would like to see the following in those new tests |
devnexen
reviewed
Jul 25, 2026
| } | ||
| /* }}} */ | ||
|
|
||
| static bool soap_class_map_is_valid(const HashTable *class_map) |
Member
There was a problem hiding this comment.
name a bit misleading since you check only the keys
Co-Authored-By: David CARLIER <devnexen@gmail.com>
Update SOAP section to clarify changes in classmap option and WSDL parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, SOAP only rejected packed arrays, which still allowed sparse integer-keyed arrays and mixed string integer-keyed arrays to be accepted.
Since
classmapis expected to be an associative mapping, arrays containing integer keys are now rejected consistently.